-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appId to push/pull data for x-provided-by #618
Conversation
if let Some(Value::Object(result_properties_map)) = | ||
result_type_map.get("properties") | ||
{ | ||
return Some(result_properties_map.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is some deep nesting!
Could maybe do some early returns so it flattens it out a bit.
Can't the spec also be deserialized into a struct so we don't have to check if it has each field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah meant to look into that when I wrote this, guess I forgot :)
Minimum allowed line rate is |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist