Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appId to push/pull data for x-provided-by #618

Merged
merged 17 commits into from
Sep 27, 2024
Merged

Conversation

pahearn73
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

if let Some(Value::Object(result_properties_map)) =
result_type_map.get("properties")
{
return Some(result_properties_map.clone());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is some deep nesting!
Could maybe do some early returns so it flattens it out a bit.

Can't the spec also be deserialized into a struct so we don't have to check if it has each field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah meant to look into that when I wrote this, guess I forgot :)

Copy link

Code Coverage

Package Line Rate Health
core.main.src.broker 42%
core.sdk.src.framework 75%
core.main.src 0%
core.sdk.src.api.manifest 91%
core.launcher.src 0%
core.sdk.src.extn.ffi 80%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
device.thunder_ripple_sdk.src 15%
core.main.src.bootstrap.extn 0%
core.main.src.state 24%
core.sdk.src.api.observability 68%
distributor.general.src 2%
core.main.src.processor 0%
core.main.src.processor.storage 0%
core.sdk.src.api.device 77%
core.sdk.src.api 78%
core.main.src.broker.thunder 54%
core.sdk.src.utils 53%
core.main.src.bootstrap 0%
device.thunder.src 0%
core.main.src.service.apps 47%
core.tdk.src.utils 0%
core.sdk.src.api.firebolt 77%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.extn 83%
core.main.src.service.extn 40%
core.launcher.src.manager 7%
device.mock_device.src 52%
core.main.src.service 31%
core.main.src.utils 27%
core.sdk.src.api.gateway 85%
openrpc_validator.src 80%
core.main.src.firebolt 4%
core.main.src.state.cap 43%
core.main.src.bootstrap.manifest 0%
device.thunder_ripple_sdk.src.client 74%
device.thunder_ripple_sdk.src.processors 10%
core.main.src.firebolt.handlers 9%
core.sdk.src.api.distributor 84%
core.sdk.src.extn.client 91%
device.thunder.src.bootstrap 0%
Summary 44% (18023 / 41373)

Minimum allowed line rate is 42%

@pahearn73 pahearn73 merged commit d19ad9f into main Sep 27, 2024
7 checks passed
@pahearn73 pahearn73 deleted the pahearn_RPPL-2310 branch September 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants