Prevent caching of delegate closures #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two different closures using the same parameter name should not end up with the same parameters.
shadowhand
commented
Apr 7, 2017
| @@ -75,7 +75,7 @@ public function getParamTypeHint(\ReflectionFunctionAbstract $function, \Reflect | |||
| $paramCacheKey = self::CACHE_KEY_CLASSES . "{$lowClass}.{$lowMethod}.param-{$lowParam}"; | |||
| } else { | |||
| $lowFunc = strtolower($function->name); | |||
| $paramCacheKey = ($lowFunc !== '{closure}') | |||
There was a problem hiding this comment.
This match only works with closures defined outside of all namespace. It seems like the original intent was to exclude all closures, which makes sense.
There was a problem hiding this comment.
Correct, thanks a lot for catching and fixing :-)
There was a problem hiding this comment.
@bwoebi would it be possible to have this tagged in a release? I've got some code that is using funky param names to avoid this bug.
There was a problem hiding this comment.
Yeah, I'm up to, just not done yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two different closures using the same parameter name should not end up
with the same parameters.