Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor help #771

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Refactor help #771

merged 2 commits into from
Nov 16, 2023

Conversation

jochenklar
Copy link
Member

Description

This PR:

  • Adds a custom {more} markdown tag
  • Adjusts the style for the details/summary html tags

Related issue: #595

@jochenklar jochenklar added this to the 2.1.0 milestone Oct 6, 2023
@jochenklar jochenklar self-assigned this Oct 6, 2023
@jochenklar jochenklar marked this pull request as ready for review October 6, 2023 13:53
@MyPyDavid
Copy link
Member

how does one reproduce this with the {more} tag??

@jochenklar
Copy link
Member Author

jochenklar commented Nov 14, 2023 •
edited
Loading

If you use {more} in any help text, the show more tag should be visible.

@MyPyDavid
Copy link
Member

thanks, found it!
And what about Uebersetzung?

Bitte beschreiben Sie kurz das Projekt und dessen Ziele. ... (show more)

@jochenklar
Copy link
Member Author

Lets do the translations when we merged everything together.

@jochenklar jochenklar merged commit 2f278c5 into dev-2.1.0 Nov 16, 2023
12 checks passed
@jochenklar jochenklar deleted the refactor_help branch December 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

@jochenklar jochenklar

Labels
status:acceptance
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid