Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset don't work #119

Closed
keldi23 opened this issue Mar 16, 2020 · 7 comments · Fixed by #129
Closed

Offset don't work #119

keldi23 opened this issue Mar 16, 2020 · 7 comments · Fixed by #129
Assignees
Labels
🐛 bug Something isn't working

Comments

@keldi23
Copy link

keldi23 commented Mar 16, 2020

Hello,

when I choose "Sunset End" with an offset in minutes, it don't work. Especially over an offset of 20.
When I change the offset from 20 to 30 minutes it will change from 19:02 to 19:42.

Best Regards
Stefan

@Hypnos3 Hypnos3 self-assigned this Mar 16, 2020
@Hypnos3
Copy link
Collaborator

Hypnos3 commented Mar 18, 2020

Hi there,

Would it be possible for you to tell me where you see this behavior?

The collection now contains 8 nodes where multiple times can be entered an Offset, used in execution and in several places used for display times.

Thanks & Greetings
Robert

@keldi23
Copy link
Author

keldi23 commented Mar 19, 2020

Hello,

thanks for your answer.
I want to take some screenshots today. I just had some other Bugs.
After full deploy everything was ok. So I think it was a problem of Node-Red.

Thank you

@keldi23 keldi23 closed this as completed Mar 19, 2020
@keldi23 keldi23 reopened this Mar 26, 2020
@keldi23
Copy link
Author

keldi23 commented Mar 26, 2020

Hello,

the problem isn't solved.
I have a node "inject at time".
Time "Sonnenuntergang Ende" with offset "Number" 20 Minutes.
There ist one trigger at the time witch I can see at the node. 19:18 o clock.
But the problem is a second trigger 20 minutes later at 19:38.
How can I solve the problem?

Greets

@Hypnos3
Copy link
Collaborator

Hypnos3 commented Mar 27, 2020

Unfortunately I could not see that behavior. Could you please export your inject node?

@Hypnos3 Hypnos3 added 🕙 awaiting feedback waiting for feedback from ticket owner 🙅 worksforme This isn't reproducible by the maintainer labels Mar 27, 2020
@keldi23
Copy link
Author

keldi23 commented Mar 28, 2020

Hello,

here is my node

flows.txt.zip

@no-response no-response bot removed the 🕙 awaiting feedback waiting for feedback from ticket owner label Mar 28, 2020
@morres83
Copy link

I can confirm that there is a bug with "inject at time".
Setup:
1x inject at blue morning, offset 40 min - for action: open door
1x inject at blue evening, no offset; - for action: close door

Behavior:
Signal at 6:00am ->open door -> OK
Signal at 7:26pm -> close door -> OK
Signal at 8:13pm -> open door -> not OK
Signal at 8:40pm -> open door -> not OK
At this point I realized the malfunction (because I get Telegram messages), and I checked node-red. The NEXT expected time for "open door" as shown in the flow below the "inject at time" block was 8:40pm NEXT day, which is obviously also wrong.

BR,
morres

@Hypnos3
Copy link
Collaborator

Hypnos3 commented Mar 31, 2020

I have also seen this in the meantime and I still searching the problem.

@Hypnos3 Hypnos3 added 🐛 bug Something isn't working and removed 🙅 worksforme This isn't reproducible by the maintainer labels Mar 31, 2020
Hypnos3 added a commit that referenced this issue Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants