Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blind control - manual override with -1 value is not working #387

Closed
89Amaterasu opened this issue Jan 3, 2022 · 4 comments
Closed

blind control - manual override with -1 value is not working #387

89Amaterasu opened this issue Jan 3, 2022 · 4 comments
Labels
✓ already implemented Issue is already fixed/implemented in a newer Version (this Version is may be not published). 🐛 bug Something isn't working

Comments

@89Amaterasu
Copy link

Manual override using the level -1 is not working as expected.

Expected behavior:
When a manual override expires, the node is expected to revert back to the automatic calculated level, e.g. the cover closes again after it has been manually opened.

Issue:
When sending -1 as the manual override level, the override is activated and expires as expected, but the cover does not revert back to the expected level, e.g. the cover does not close again after it has been manually opened.

Using levels other than -1, the manual override is working as expected and the cover reverts back to the expected level, e.g. closes again after it has been manually opened.

Does somebody have the same issue?

@Hypnos3 Hypnos3 added 🐛 bug Something isn't working 🙅 worksforme This isn't reproducible by the maintainer labels Jan 8, 2022
@Hypnos3
Copy link
Collaborator

Hypnos3 commented Jan 15, 2022

It is working for me.
Under the node should be the time when the manual override expires:
image

This time will be changed if another override arrives.

Do you sending the -1 continuously?

@Hypnos3 Hypnos3 added the 🕙 awaiting feedback waiting for feedback from ticket owner label Jan 15, 2022
@89Amaterasu
Copy link
Author

The issue is not the override not expiring, but rather that the level is not adjusted upon expiration.

If the default level is 100 and the cover level is manually changed to a certain unknown level (-1), the cover stays at the manually set level after expiration. I would expect the cover to revert back to 100.

Everything works fine and as expected for manual levels between 0 and 100 but not in case of -1. I hope that makes it more clear :)

In case of a -1 level override, the node just stays with the previous level and just adds a override to that. Since the node level does not change upon expiration, the node does not fire.

A quick fix would be the node firing after a -1 expiration.

Manual -1 override:
100 --> 100(override) --> 100
Manual 50 override:
100 --> 50 (override) --> 100

@no-response no-response bot removed the 🕙 awaiting feedback waiting for feedback from ticket owner label Jan 16, 2022
@Hypnos3 Hypnos3 removed the 🙅 worksforme This isn't reproducible by the maintainer label Jan 16, 2022
Hypnos3 added a commit that referenced this issue Jan 16, 2022
  - after expire of manual override with -1 force to send output #387
  - add possibility to force output to first output when topic contains `forceOutput`
@Hypnos3
Copy link
Collaborator

Hypnos3 commented Jan 16, 2022

Ok I got it and was able to reproduce it. Will be fixed with the next release.

@Hypnos3 Hypnos3 added the ✓ already implemented Issue is already fixed/implemented in a newer Version (this Version is may be not published). label Jan 16, 2022
@89Amaterasu
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✓ already implemented Issue is already fixed/implemented in a newer Version (this Version is may be not published). 🐛 bug Something isn't working
Development

No branches or pull requests

2 participants