Skip to content
This repository has been archived by the owner on Aug 30, 2020. It is now read-only.

Added multiple *.pro files support #47

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added multiple *.pro files support #47

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2016

No description provided.

@@ -252,11 +252,19 @@ def run(cmd, *args, **kwargs):

elif(pro_files):
# qmake
# make sure there is only one .pro file
if len(pro_files) != 1:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a bit simpler if you used len(...) == 1 and swapped the blocks.

@rdnetto
Copy link
Owner

rdnetto commented Jan 28, 2016

Thanks for the PR. Would you mind explaining what the use case for having multiple .pro files in a given directory is?

@ghost
Copy link
Author

ghost commented Jan 28, 2016

Thanks for ur answer :) I cant invent real use case for it, but i have legacy project with multiple .pro files in root directory. Basically it's 3 different projects with shared libraries and it can be redisigned, but this wasn't problem yet and we have configured CI and etc for this setup. I tried ur plugin and noticed that its not very comfortable to do mv to other .pro files :)

Sorry for my English, i am not native speaker.

@rdnetto
Copy link
Owner

rdnetto commented Jan 29, 2016

OK, makes sense. I'd prefer to have avoided something that depends on interactive input (see #48), but this is a fairly niche case and I can't think of a better alternative.

Don't worry about your English, it's easily understood. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants