Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility with PHPUnit 11 #81

Closed
wants to merge 1 commit into from

Conversation

dmaicher
Copy link

Fixes #80

@@ -10,6 +10,7 @@
use PHPUnit\Framework\ExpectationFailedException;
use PHPUnit\SebastianBergmann\Comparator\ComparisonFailure as Phar_ComparisonFailure;
use SebastianBergmann\Comparator\ComparisonFailure;
use SebastianBergmann\Exporter\Exporter;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this will break when people use the PHPUnit PHAR file to run tests

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be interesting to find a way to run a test suite with phar in these cases right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added that (running the test against PHARs in CI) for the PHPUnit Polyfills too. You should be able to use that change as an example for how to set that up: Yoast/PHPUnit-Polyfills#160

Also note that the latest PHPUnit releases contain a change in how the PHARs are build, so now you need to take three different potential class names into account for the Exporter.... See: Yoast/PHPUnit-Polyfills#161 for how I solved this in the PHPUnit Polyfills.

@dmaicher
Copy link
Author

dmaicher commented Jun 7, 2024

Currently not using this library anymore so I won't invest any more time here

@dmaicher dmaicher closed this Jun 7, 2024
@dmaicher dmaicher deleted the phpunit_11 branch June 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PHPUnit 11
3 participants