Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "see also" links on suspense page #55

Closed
wants to merge 1 commit into from

Conversation

bruceharris
Copy link
Contributor

No description provided.

@voliva
Copy link
Collaborator

voliva commented Mar 2, 2023

Hey @bruceharris, thank you for raising this.

However the links on https://react-rxjs.org/docs/api/core/suspense all seem to work on my end, is this the page the links are broken?

The CI flagged that the new links of this PR are broken.

Error: Broken links found!

- Page path = /docs/api/core/suspense:
   -> link to ../../utils/suspend (resolved as: /docs/utils/suspend)
   -> link to ../../utils/suspended (resolved as: /docs/utils/suspended)

@bruceharris
Copy link
Contributor Author

Hmm, links go to "page not found" for me. broken links

@voliva
Copy link
Collaborator

voliva commented Mar 2, 2023

Ok I see, it happens when accessing directly into the page. If you navigate through the menu to SUSPENSE, then the links work alright.

The only difference I see is that when navigating through the menu the URL doesn't end with /, whereas when navigating directly it does end with /. I'm thinking Docusaurs bug? I'll try to investigate later on.

@voliva voliva mentioned this pull request Mar 5, 2023
@voliva
Copy link
Collaborator

voliva commented Mar 5, 2023

Indeed, it was an issue on docusaurus + github pages: facebook/docusaurus#5026

They released a newer version with a config option to fix it, so I raised #56 that does the upgrade and configures it.

@bruceharris
Copy link
Contributor Author

👍 thanks @voliva !

@bruceharris bruceharris closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants