-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MacOS support #16
base: master
Are you sure you want to change the base?
Conversation
Hi @biggoldendragon, thanks for your contribution. I don't have the possibility to test this on a Mac, but the changes look reasonable. Just one suggestion. Wouldn't it make more sense to use |
Hi @florian-wagner, I agree with your change for computing the filesize variable. I've made the change, tested that it works great on OS X and check-in the updated code on this branch. Thanks! |
Hi @biggoldendragon, thanks for your changes. I tested your Pull request and I get
Why did you introduce the |
Hi @florian-wagner, I introduced Also, on the main branch, line 22 says My branch changed that section of the script, but perhaps I've changed way to much in an effort to get the script running? |
I suggest an alternative way to support osx here: https://github.com/reHackable/maxio/pull/22/files |
@@ -62,7 +69,7 @@ fi | |||
sed -i -e "s/^[[:blank:]]*$/Blank/" "${tmpfolder}"/*.pagedata | |||
|
|||
filename=$(grep -F '"visibleName"' "${tmpfolder}"/*.metadata | cut -d: -f2- | grep -o '"[^"]*"') | |||
echo "Exporting notebook ${filename} ($(wc -l "${tmpfolder}"/*.pagedata | cut -d\ -f1) pages)" | |||
echo "Exporting notebook ${filename} ($(ls -1 "${tmpfolder}"/*.pagedata | wc -l | awk '{print $1}') pages)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ls
does -1
automatically in a pipe so it's not needed here
Added Readme to explain how to use this package on MacOS. Updated exportNotebook to support MacOS. I can't test on Linux to ensure the changes are nondestructive.