Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve packages names to example imports #300

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

ahmadatallah
Copy link
Contributor

@ahmadatallah ahmadatallah commented Oct 12, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.js entry file
    • Type definitions in an index.d.ts file are desired but not required for the PR to be merged
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

@chaance chaance added the Type: Enhancement General improvements or suggestions label Oct 14, 2019
@chaance
Copy link
Member

chaance commented Oct 14, 2019

Looks good, thanks @syncatallah!

@chaance chaance changed the title Add packages names in examples import. Add packages names to example imports Oct 14, 2019
@chaance chaance changed the title Add packages names to example imports Resolve packages names to example imports Oct 14, 2019
@chaance chaance merged commit 7f9fde3 into reach:master Oct 14, 2019
@mjackson
Copy link
Member

Awesome, thanks @syncatallah!

chaance pushed a commit that referenced this pull request Oct 23, 2019
* add packages names in examples import

* storybook/add webpack configurations
@ahmadatallah ahmadatallah deleted the examples-import-rui#1 branch November 28, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants