[Combobox] Update openOnFocus example to work even with empty input #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
openOnFocus
example mounts/unmounts the popover based on the results array state, which returns null if the input term is an empty string. This is confusing in the context of theopenOnFocus
prop because the popover doesn't show on focus if the input is empty.An alternative to using hardcoded example options would be to use a variant of
useCityMatch
that returns an array of e.g. the first 10 cities if the input term is an empty string.Old Example
New Example
Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
yarn test
).yarn start
).This pull request: