Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace omitBsProps with splitBsProps #2052

Merged
merged 2 commits into from
Jul 20, 2016
Merged

Replace omitBsProps with splitBsProps #2052

merged 2 commits into from
Jul 20, 2016

Conversation

taion
Copy link
Member

@taion taion commented Jul 14, 2016

No description provided.

@taion
Copy link
Member Author

taion commented Jul 14, 2016

This is the last bit of follow-up to #1994.

I guess I also dropped lodash-compat as a dependency here and just added lodash as a dev dependency.

This was referenced Jul 14, 2016
Closed
Closed
@BorelTung
Copy link

When will we merge this PR and cut a new release? I really need it since I want to use react-bootstrap with react@15.2.1.

jquense
jquense reviewed Jul 19, 2016
View reviewed changes
src/utils/bootstrapUtils.js
return [getBsProps(props), elementProps];
}

export function splitBsPropsAndOmit(props, omittedPropNames) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why two utils here? seems like you could just roll this into splitBsProps above yeah?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a slight optimization... just two statically separate functions rather than a branch in the same function. Figure it's worth it since we call this literally everywhere.

@taion
Copy link
Member Author

taion commented Jul 19, 2016

Updated.

@taion
Copy link
Member Author

taion commented Jul 19, 2016

Good to go now?

@jquense
Copy link
Member

jquense commented Jul 20, 2016

:shipit:

@BarryOSeven
Copy link

Who is the hero who will save everybody?

@hdrdavies
Copy link

so tense....

@taion taion merged commit 2ae75bd into react-bootstrap:next Jul 20, 2016
@taion taion deleted the splitBsProps branch July 20, 2016 15:49
@lynn
Copy link

lynn commented Jul 20, 2016

Whoo, thank you! 🎊🎉

@marceloemanoel
Copy link

Hi guys, first of all thank you all. How can I use this update? I did install "react-bootstrap/react-bootstrap#next" but now I can't import anything from 'react-bootstrap'. :(

@davidfurlong
Copy link

New release: https://github.com/react-bootstrap/react-bootstrap/releases/tag/v0.30.0-rc.1

@marceloemanoel
Copy link

Thanks! :D

@renovate renovate bot mentioned this pull request Oct 10, 2018
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@taion @BorelTung @jquense @BarryOSeven @hdrdavies @lynn @marceloemanoel @davidfurlong