Drop warning #488
Closed
Drop warning #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tend to remove warning because of confusing api. It's hard to say by which condition warning is shown. This package also requires babel plugin setup which is forgotted here. IMO it's much easier to just write console statement and choose either console.warn or console.error than dealing with this commonjs-only package.
|
eh... i'm not that bothered by the API. it's also more or less ubiquitous at this point. @TrySound would you be happier if we switched to |
|
I'm not really a fan of this convention anymore caz it's confused me a few times lately. Also tiny-warning uses console.warn which is kinda a breaking change. Though it's not me to decide :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tend to remove warning because of confusing api. It's hard to say by
which condition warning is shown. This package also requires babel
plugin setup which is forgotted here. IMO it's much easier to just write
console statement and choose either console.warn or console.error than
dealing with this commonjs-only package.