Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/post page #55

Merged
merged 70 commits into from
Feb 16, 2023
Merged

Feat/post page #55

merged 70 commits into from
Feb 16, 2023

Conversation

Jeremy-Kr
Copy link
Collaborator

What is this PR? πŸ”

  • κ²Œμ‹œλ¬Ό μž‘μ„± κΈ°λŠ₯을 μ œμž‘ν•©λ‹ˆλ‹€.

branch

  • feat/PostPage -> dev

Changes πŸ“

  • μ—¬λŸ¬κ°€μ§€ 변경사항이 μžˆμœΌλ‹ˆ μ½”λ“œ μ½μ–΄μ£Όμ„Έμš” ^^;

#5 #41 by @arch-spatula @Jeremy-Kr @hyoloui

nno3onn and others added 30 commits February 13, 2023 11:34
@nno3onn @hyoloui
feat(DefaultButton): onClick 속성 μΆ”κ°€
e04eac5 
Common Components 개발 #8
@nno3onn @hyoloui
feat(Banner): Banner μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
8ed1dc2
@nno3onn @hyoloui
fix: ν”Όλ“œλ°± 반영
7bf280a
@nno3onn @hyoloui
feat(Tabs): Tabs μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
952d316
@nno3onn @hyoloui
fix: λΆˆν•„μš”ν•œ μ½”λ“œ 제거
4027d23
@nno3onn @hyoloui
fix: ν”Όλ“œλ°± 반영
bc37ce1
@nno3onn @hyoloui
feat(SwitchButton): MyPage의 SwitchButton μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
eaa2677
@nno3onn @hyoloui
fix: ν”Όλ“œλ°± 반영
f97e665
@nno3onn @hyoloui
feat(PositionTag): MyPage의 PositionTag μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
8d53eba
@nno3onn @hyoloui
fix: ν”Όλ“œλ°± 반영
7229c1c
@nno3onn @hyoloui
feat(ProfileContainer): MyPage의 ProfileContainer μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
9e7dcb0
@nno3onn @hyoloui
fix: ν”Όλ“œλ°± 반영
f70192e
@arch-spatula @hyoloui
feat: Tags μ»΄ν¬λ„ŒνŠΈ UI 생성
d458229 
tags μ»΄ν¬λ„ŒνŠΈ 둜직 없이 UI만 μƒμ„±ν•©λ‹ˆλ‹€.
tagsλŠ” κ°œλ³„ tag의 λ¬ΆμŒμž…λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
refactor: Tags.tsx Props type μ‹λ³„μžλͺ… μˆ˜μ •
9498b96 
- TagsItemsλ₯Ό tagItems둜 λ³΅μˆ˜ν˜•μ˜ λ³΅μˆ˜ν˜•μ„ λ‹¨μˆ˜ν˜•μ˜ λ³΅μˆ˜ν˜•μœΌλ‘œ μˆ˜μ •ν•©λ‹ˆλ‹€.
    - 볡수의 λͺ©λ‘μ΄ μ•„λ‹Œ 단일 λͺ©λ‘μ΄κΈ° λ•Œλ¬Έμ— λ³€κ²½ν•©λ‹ˆλ‹€.
    - 파슀칼 μΌ€μ΄μŠ€λ₯Ό μΌ€λ©€μΌ€μ΄μŠ€λ‘œ μˆ˜μ •ν•©λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
feat: Card.tsx, IconCount.tsx: μ»΄ν¬λ„ŒνŠΈ μ΅œμ΄ˆκ΅¬ν˜„
95cb625 
- ν°ν‹€μ—μ„œ Card μ»΄ν¬λ„ŒνŠΈλ₯Ό κ΅¬ν˜„ν•©λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
refactor(CardItem, Tags, IconCount): 쀑앙정렬, λ¬Έμ„œν™”
e7ed400 
- λͺ¨λ“ˆλͺ… Cardμ—μ„œ CardItem으둜 λ³€κ²½
    - μŠ€νƒ€μΌλ§ μ •λ ¬ν•©λ‹ˆλ‹€.
    - μ‚¬μš©μ˜ˆμ‹œλ₯Ό λ¬Έμ„œν™”ν•©λ‹ˆλ‹€.
- Tagsλ₯Ό μˆ˜μ •ν•©λ‹ˆλ‹€.
    - κ°€μš΄λ° μ •λ ¬ν•©λ‹ˆλ‹€.
    - λ§Žμ•„μ§€λ©΄ μ€„λ°”κΏˆ μ²˜λ¦¬ν•©λ‹ˆλ‹€.
    - tagsλ₯Ό μΆ”κ°€ μž‘μ—…μ„ λ¬Έμ„œν™”ν•©λ‹ˆλ‹€.
- IconCount μ»΄ν¬λ„ŒνŠΈ ν…μŠ€νŠΈλ₯Ό μ€‘μ•™μ •λ ¬ν•©λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
refactor (IconWithCount, Tags): λͺ¨λ“ˆλͺ… μˆ˜μ •, Tag μ€„λ°”κΏˆ λ³€κ²½
a9caa44 
- λͺ¨λ“ˆλͺ… IconCountλ₯Ό IconWithCount둜 λ³€κ²½ν•©λ‹ˆλ‹€.
- tags μ€„λ°”κΏˆ λŒ€μ‹ μ— μ—¬λŸ¬ νƒœκ·Έμ— (...)으둜 λ³€κ²½ν•©λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
feat (ico-hart.svg): μ’‹μ•„μš” μ•„μ΄μ½˜ μΆ”κ°€
f3ec1d2 
- ico-heart μ•„μ΄μ½˜μ„ μΆ”κ°€ν•©λ‹ˆλ‹€.

#8
@arch-spatula @hyoloui
docs (CardItem, Tags): λͺ¨λ“ˆλͺ…κ³Ό μ»΄ν¬λ„ŒνŠΈ 이름 톡일 Tag λ¬Έμ„œν™”
c52786b 
- Tag μΆ”κ°€ λ¬Έμ„œν™”
    - μ€„λ°”κΏˆ 문제 κ°€λ‘œμŠ€ν¬λ‘€ 지원 μ—¬λΆ€ μ„ νƒμ§€λ‘œ μΆ”κ°€ λ¬Έμ„œν™”
- μ»΄ν¬λ„ŒνŠΈλͺ… λͺ¨λ“ˆλͺ…κ³Ό 톡일

#8
@hyoloui
chore: toast ui Add dependencieds
aa2839f 
- ν† μŠ€νŠΈ ui 적용으둜 라이브러리 μ„€μΉ˜ν•˜μ˜€μŠ΅λ‹ˆλ‹€.(λ””νŽœλ˜μ‹œ)
#8
@by hyoloui
@hyoloui
Revert "chore: toast ui Add dependencieds"
aaa7b18 
This reverts commit d51b646.
@hyoloui
feat: DropDown.tsx: μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
e48ad53 
- λ‘œμ§λΆ€λΆ„ μš°μ„  처리

#8
@hyoloui
style: DropDown μŠ€νƒ€μΌ 적용
4d6f749 
#8
@hyoloui
feat: DropDown types κ°„μ†Œν™”
d359b1b 
#8
@hyoloui
refac: DropDown ν”Όλ“œλ°± 반영
6d43e06 
- ν”Όλ“œλ°± λ°˜μ˜ν•˜μ—¬ μž‘μ—… μ™„λ£Œ ν–ˆμŠ΅λ‹ˆλ‹€. @Jeremy-Kr @nno3onn @arch-spatula

#8
@hyoloui
refac: DropDown type
ac90153 
-λ“œλ‘­λ‹€μš΄ μ»΄ν¬λ„ŒνŠΈμ— μ „λ‹¬λ˜λŠ” ν”„λ‘­μŠ€ νƒ€μž…μ„ μ œλ„€λ¦­μ„ ν™œμš©ν–ˆμŠ΅λ‹ˆλ‹€.

#8
@yunjunhojj @hyoloui
feat: 둜그인 λ²„νŠΌ 생성 #6
237b211
@yunjunhojj @hyoloui
feat: 둜그인 λ²„νŠΌ export μ‹ κΈ°μˆ  λ„μž…
49a40e8
@yunjunhojj @hyoloui
feat: μ“Έλ°μ—†λŠ” μ½”λ“œ μ‚­μ œ #6
1500798
@yunjunhojj @hyoloui
Update index.tsx
fc3469b
@Jeremy-Kr Jeremy-Kr added the enhancement μƒˆλ‘œμš΄ κΈ°λŠ₯ label Feb 15, 2023
@vercel
Copy link

vercel bot commented Feb 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
codefolio ❌ Failed (Inspect) Feb 16, 2023 at 0:40AM (UTC)

arch-spatula
arch-spatula approved these changes Feb 15, 2023
View reviewed changes
types.d.ts Outdated Show resolved Hide resolved
Components/Post/PostEditor.tsx Outdated Show resolved Hide resolved
Components/Post/PostEditor.tsx Outdated Show resolved Hide resolved
Components/Post/PostEditor.tsx Outdated Show resolved Hide resolved
@arch-spatula
docs(PostEditor, types): λΆˆν•„μš”ν•œ 주석 및 ν‚€μ›Œλ“œ μ‚­μ œ
118f27f 
- PostEditor의 λΆˆν•„μš”ν•œ 주석을 μ‚­μ œν•©λ‹ˆλ‹€.
- types.d.ts의 declareλ₯Ό μ‚­μ œν•©λ‹ˆλ‹€.

#5
yunjunhojj
yunjunhojj approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@yunjunhojj yunjunhojj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 λ§ν•˜λ €ν–ˆλŠ”λ° μƒν˜„λ‹˜μ˜ μ„ΌμŠ€μžˆλŠ” 처리...κ°μ‚¬ν•©λ‹ˆλ‹€!

hyoloui
hyoloui reviewed Feb 15, 2023
View reviewed changes
Components/Post/Post.tsx Outdated Show resolved Hide resolved
hyoloui
hyoloui approved these changes Feb 15, 2023
View reviewed changes
Components/Post/Post.tsx Outdated Show resolved Hide resolved
Components/Post/Post.tsx Outdated Show resolved Hide resolved
Components/Post/Post.tsx Outdated Show resolved Hide resolved
types.d.ts
@@ -1,6 +1,8 @@
import { WithPersonType } from "./Components/Post/WithPeople";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 잠깐 μž‘μ—…ν•˜λ‹€κ°€ import λ˜μ—ˆλŠ”λ° μ‚­μ œ ν•΄μ•Όκ² μ–΄μš”

Components/Post/ProjectInfoDropDown.tsx Outdated Show resolved Hide resolved
Components/Post/PostTitle.tsx Outdated Show resolved Hide resolved
Components/Post/PostTitle.tsx Outdated Show resolved Hide resolved
@Jeremy-Kr Jeremy-Kr merged commit 70d74c0 into dev Feb 16, 2023
@Jeremy-Kr Jeremy-Kr deleted the feat/PostPage branch February 16, 2023 00:40
@Jeremy-Kr Jeremy-Kr restored the feat/PostPage branch February 16, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunhojj yunjunhojj yunjunhojj approved these changes

@nno3onn nno3onn nno3onn approved these changes

@arch-spatula arch-spatula arch-spatula approved these changes

@hyoloui hyoloui hyoloui approved these changes

Assignees

@yunjunhojj yunjunhojj

@nno3onn nno3onn

@arch-spatula arch-spatula

@Jeremy-Kr Jeremy-Kr

@hyoloui hyoloui

Labels
enhancement μƒˆλ‘œμš΄ κΈ°λŠ₯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jeremy-Kr @yunjunhojj @nno3onn @arch-spatula @hyoloui