fix: page scroll position will jump after dialog is closed #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/dialog/pzgk4aqxs |
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 3 3
Lines 189 189
Branches 53 53
=======================================
Hits 174 174
Misses 15 15
Continue to review full report at Codecov.
|
hengkx
reviewed
Sep 2, 2020
23 tasks
hengkx
reviewed
Sep 2, 2020
| this.lastOutSideFocusNode = null; | ||
| } | ||
| this.lastOutSideFocusNode = null; | ||
| } | ||
| if (afterClose) { |
There was a problem hiding this comment.
try {
this.lastOutSideFocusNode.focus();
} catch (e) {
-- this.lastOutSideFocusNode = null; // 没看懂这一行的作用
}
this.lastOutSideFocusNode = null;// 在这里已经设置了null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ant-design/ant-design#26528