-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dialog dont close when mouseDown in content and mouseUp in wrapper #210
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/dialog/jwga1l7fq |
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 98.07% 98.08% +0.01%
==========================================
Files 6 6
Lines 156 157 +1
Branches 45 45
==========================================
+ Hits 153 154 +1
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
Thank you! Waiting for these changes in the release version. |
This is particularly bad when the Dialog has a child TextArea. I'll try to select the contents of the TextArea with my mouse and accidentally mouseup outside of the dialog, closing everything. Glad to see a fix is coming. Any idea when this will make it in to master? |
Conflicting |
done |
|
ref ant-design/ant-design#27391