Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialog dont close when mouseDown in content and mouseUp in wrapper #210

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

littleee
Copy link
Contributor

@littleee littleee commented Nov 2, 2020

@vercel
Copy link

vercel bot commented Nov 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/jwga1l7fq
✅ Preview: https://dialog-git-master.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #210 (3e7dfe8) into master (cba467a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   98.07%   98.08%   +0.01%     
==========================================
  Files           6        6              
  Lines         156      157       +1     
  Branches       45       45              
==========================================
+ Hits          153      154       +1     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/Content/index.tsx 95.23% <ø> (ø)
src/Dialog/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba467a...3e7dfe8. Read the comment docs.

@ThreshHNS
Copy link

Thank you! Waiting for these changes in the release version.

@scotthwsnyder
Copy link

This is particularly bad when the Dialog has a child TextArea. I'll try to select the contents of the TextArea with my mouse and accidentally mouseup outside of the dialog, closing everything. Glad to see a fix is coming. Any idea when this will make it in to master?

@afc163
Copy link
Member

afc163 commented Dec 1, 2020

Conflicting

@littleee
Copy link
Contributor Author

littleee commented Dec 1, 2020

Conflicting

done

@zombieJ zombieJ merged commit d185715 into react-component:master Dec 3, 2020
@zombieJ
Copy link
Member

zombieJ commented Dec 3, 2020

+ rc-dialog@8.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants