Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Should not re-render when dialog is invisible #212

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 16, 2020

@vercel
Copy link

vercel bot commented Nov 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/4bop1ngtp
✅ Preview: https://dialog-git-fix-render.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #212 (0a32dd3) into master (99ebd4f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   98.05%   98.07%   +0.02%     
==========================================
  Files           5        6       +1     
  Lines         154      156       +2     
  Branches       45       45              
==========================================
+ Hits          151      153       +2     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/Content/MemoChildren.tsx 100.00% <100.00%> (ø)
src/Dialog/Content/index.tsx 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ebd4f...0a32dd3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal组件设置destroyOnClose={true},关闭modal时依然执行了被modal包裹的组件
1 participant