Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: ScrollLocker call related #227

Merged
merged 1 commit into from
Jan 7, 2021
Merged

improve: ScrollLocker call related #227

merged 1 commit into from
Jan 7, 2021

Conversation

shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Jan 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/ola17tmya
✅ Preview: https://dialog-git-improve-scoll-locker.react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #227 (fa49a23) into master (9238fb6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   98.07%   98.11%   +0.03%     
==========================================
  Files           6        6              
  Lines         156      159       +3     
  Branches       45       46       +1     
==========================================
+ Hits          153      156       +3     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9238fb6...fa49a23. Read the comment docs.

@shaodahong shaodahong requested a review from afc163 January 7, 2021 02:47
@afc163 afc163 merged commit 75a2456 into master Jan 7, 2021
@afc163 afc163 deleted the improve-scoll-locker branch January 7, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants