Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:enable the left or right keyboard to switch image #117

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

zpc7
Copy link
Contributor

@zpc7 zpc7 commented Apr 9, 2022

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

语言 更新描述
🇺🇸 英文 When the picture is previewed, you can use the left and right arrow keys to switch
🇨🇳 中文 图片预览时, 可使用左右方向键进行切换

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@vercel
Copy link

vercel bot commented Apr 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/GMSdJ5d6ExFVqa5MqYfCYmABLokP
✅ Preview: https://image-git-fork-zpc7-master-react-component.vercel.app

@zpc7
Copy link
Contributor Author

zpc7 commented Apr 9, 2022

There is this issue in antd-design
Image 显示 count / total 浏览进度的标题,支持键盘左右查看上一张和下一张
this PR is only used to add the events of the left and right arrow keys when previewing multiple pictures.

You can get a quick preview via the link below:
https://image-git-fork-zpc7-master-react-component.vercel.app/demo/previewgroup

Reviews and feedback welcome @afc163 @zombieJ 😃

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #117 (21d0250) into master (fdb9c0b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          254       266   +12     
  Branches        71        76    +5     
=========================================
+ Hits           254       266   +12     
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

src/Preview.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Apr 12, 2022

+ rc-image@5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants