Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add top progress when use PreviewGroup #118

Merged

Conversation

zpc7
Copy link
Contributor

@zpc7 zpc7 commented Apr 13, 2022

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

Image 希望显示 current / total 浏览进度的标题

💡 需求背景和解决方案

📝 更新日志

语言 更新描述
🇺🇸 英文 preview group adds the title of the browsing progress at the top
🇨🇳 中文 PreviewGroup 添加顶部浏览进度的标识

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/8nMG7UmibBqtLuh7BLSo5vDfLywC
✅ Preview: https://image-git-fork-zpc7-feature-preview-grou-43d4f0-react-component.vercel.app

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #118 (cb57465) into master (82b2eae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          266       271    +5     
  Branches        76        81    +5     
=========================================
+ Hits           266       271    +5     
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <100.00%> (ø)
src/PreviewGroup.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

src/Preview.tsx Outdated Show resolved Hide resolved
@zpc7 zpc7 force-pushed the feature/preview-group-top-progress branch from 96d9462 to cb57465 Compare April 13, 2022 16:10
@afc163 afc163 merged commit 0fdec11 into react-component:master Apr 14, 2022
@zombieJ
Copy link
Member

zombieJ commented Apr 14, 2022

+ rc-image@5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants