Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should hide preview mask when Image is hidden #123

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 26, 2022

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
image ✅ Ready (Inspect) Visit Preview Jul 26, 2022 at 8:55AM (UTC)

@afc163 afc163 changed the title fix: Image should hide preview mask when image is hidden fix: should hide preview mask when Image is hidden Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #123 (f75e104) into master (9a79995) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f75e104 differs from pull request most recent head b3a8f80. Consider uploading reports for the commit b3a8f80 to get more accurate results

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          277       278    +1     
  Branches        86        85    -1     
=========================================
+ Hits           277       278    +1     
Impacted Files Coverage Δ
src/Image.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@afc163 afc163 merged commit 27c8afe into master Jul 26, 2022
@afc163 afc163 deleted the fix/image-mask branch July 26, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using the Image component, the style shows: none or takes up space and can be clicked
1 participant