Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add width and height for <img /> #124

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

li-jia-nan
Copy link
Member

close #36914

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
image ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 6:08AM (UTC)

src/Image.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #124 (165ac9f) into master (b841d38) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          278       276    -2     
  Branches        85        83    -2     
=========================================
- Hits           278       276    -2     
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <ø> (ø)
src/getFixScaleEleTransPosition.ts 100.00% <ø> (ø)
src/Image.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

src/Image.tsx Outdated Show resolved Hide resolved
@li-jia-nan li-jia-nan requested a review from afc163 August 8, 2022 06:05
@afc163 afc163 merged commit 1134a79 into react-component:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用lighthouse分析页面性能, 发现Image组件中img标签未使用width和height属性
2 participants