fix: should not trigger isImageValid.then when src changed #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 97.90% 97.91%
=======================================
Files 13 13
Lines 382 383 +1
Branches 108 107 -1
=======================================
+ Hits 374 375 +1
Misses 7 7
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
reviewed
Sep 20, 2023
| }); | ||
|
|
||
| expect(container.querySelector('.rc-image-mask')).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('should change image, not error', () => { | ||
| it('should change image, not error', async () => { |
There was a problem hiding this comment.
老的 test case 有，但是实现逻辑变了导致它其实什么都没有测
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#44948
fix #277