Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrapClassName => classNames.wrapper #285

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

kiner-tang
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 10:03am

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #285 (d98b3ba) into master (486e0f1) will not change coverage.
The diff coverage is n/a.

❗ Current head d98b3ba differs from pull request most recent head c99e3b5. Consider uploading reports for the commit c99e3b5 to get more accurate results

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          13       13           
  Lines         383      383           
  Branches      107      107           
=======================================
  Hits          375      375           
  Misses          7        7           
  Partials        1        1           
Files Coverage Δ
src/Preview.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -370,7 +370,9 @@ const Preview: React.FC<PreviewProps> = props => {
prefixCls={prefixCls}
onClose={onClose}
visible={visible}
wrapClassName={wrapClassName}
classNames={{
wrapper: wrapClassName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapper 还是 root?

@zombieJ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像后面讨论把 wrapper 去掉了,好像这里都不需要改了,在 dialog 里面把警告去掉是不是就好了 @MadCcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants