-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preview zIndex should pass into operations #288
feat: preview zIndex should pass into operations #288
Conversation
kiner-tang
commented
Nov 21, 2023
•
edited
Loading
edited
- Image preview 的zindex在多层Modal中层级错误被遮住了 ant-design/ant-design#45975
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
style={style} | ||
style={{ | ||
...style, | ||
zIndex, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
禁止用户覆盖 zIndex 吗?其他都是这样弄的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 zIndex 本身就是从 preview 传过来用户自定义的 zIndex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSSMotion 的 style 里面有 zIndex 吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们给的应该是没有的,这个也不能参与动画计算
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
恩,那顺序不重要了
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 13 13
Lines 383 383
Branches 107 107
=======================================
Hits 375 375
Misses 7 7
Partials 1 1 ☔ View full report in Codecov by Sentry. |