Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize zIndex #289

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix: optimize zIndex #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de8c8b0
fix: operations zIndex
kiner-tang Nov 23, 2023
630791e
fix: operations zIndex
kiner-tang Nov 23, 2023
305e89b
feat: optimize code
kiner-tang Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ const Preview: React.FC<PreviewProps> = props => {
onFlipX={onFlipX}
onFlipY={onFlipY}
onClose={onClose}
zIndex={restProps.zIndex}
zIndex={restProps.zIndex !== undefined ? restProps.zIndex + 1 : undefined}
/>
</>
);
Expand Down
2 changes: 1 addition & 1 deletion tests/basic.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ describe('Basic', () => {
/>,
);
const operationsElement = baseElement.querySelector('.rc-image-preview-operations-wrapper');
expect(operationsElement).toHaveStyle({ zIndex: 9999 });
expect(operationsElement).toHaveStyle({ zIndex: 10000 });
});
});
Loading