Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: operation default icons #297

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: operation default icons #297

merged 5 commits into from
Nov 28, 2023

Conversation

kiner-tang
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ❌ Failed (Inspect) Nov 28, 2023 7:06am

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ba3514) 98.22% compared to head (8f6af37) 98.22%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          15       15           
  Lines         450      450           
  Branches      124      124           
=======================================
  Hits          442      442           
  Misses          7        7           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crazyair
crazyair reviewed Nov 28, 2023
View reviewed changes
src/Image.tsx Outdated
@@ -98,7 +121,7 @@ const ImageInternal: CompoundedComponent<ImageProps> = props => {
mask: previewMask,
maskClassName,
movable,
icons,
icons = defaultIcons,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改 Image 逻辑了？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只是加一个默认值，如果不传 icons 默认给一套 icons

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太清楚历史原因，尽量不动吧，只改 demo

@MadCcc
Copy link
Member

MadCcc commented Nov 28, 2023

不推荐这么做，rc 尽量不要依赖 icons

@kiner-tang
Copy link
Contributor Author

不推荐这么做，rc 尽量不要依赖 icons

那我就改一下demo 吧

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023

Deployment failed with the following error:

Resource is limited - try again in 6 hours (more than 100, code: "api-deployments-free-per-day").

@MadCcc MadCcc merged commit 2fe979b into react-component:master Nov 28, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazyair crazyair crazyair left review comments

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiner-tang @MadCcc @crazyair