fix: support PreviewGroup#items locating when clicking image #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vagusX
commented
May 14, 2024
•
vagusX
commented
- 修复 PreviewGroup#items 自定义时，默认定位到第 0 张的问题（因为查找按照自增 id 去查找了，此时应跳过查找）
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 99.77% 99.78%
=======================================
Files 15 15
Lines 454 456 +2
Branches 125 128 +3
=======================================
+ Hits 453 455 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
你为啥会需要这个？current 不够用么 |
zombieJ
reviewed
May 14, 2024
就是不够简洁，current 要完全受控才能用， |
vagusX
force-pushed
the
feat/support-preview-default-current
branch
from
c456ab5
to
74eba0a
Compare
vagusX
force-pushed
the
feat/support-preview-default-current
branch
from
74eba0a
to
d2fabfe
Compare
vagusX
changed the title
zombieJ
reviewed
May 15, 2024
vagusX
force-pushed
the
feat/support-preview-default-current
branch
from
124181d
to
7907e25
Compare
zombieJ
reviewed
May 15, 2024
zombieJ
reviewed
May 15, 2024
zombieJ
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.