Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type to SubMenuType and MenuItemType #693

Merged
merged 2 commits into from
Mar 25, 2024
Merged

feat: add type to SubMenuType and MenuItemType #693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76008e3
feat: add `type` to SubMenuType and MenuItemType
madocto Mar 19, 2024
56632f6
feat: rename
madocto Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ interface ItemSharedProps {
}

export interface SubMenuType extends ItemSharedProps {
type?: "sub";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type?: "sub";
type?: "submenu";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


label?: React.ReactNode;

children: ItemType[];
Expand Down Expand Up @@ -38,6 +40,8 @@ export interface SubMenuType extends ItemSharedProps {
}

export interface MenuItemType extends ItemSharedProps {
type?: 'item';

label?: React.ReactNode;

disabled?: boolean;
Expand Down
Loading