feat: add _internalComponents for antd to fix findDOMNode warning
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 antd 中，对于 MenuItem 会添加一个 Tooltip 用于收缩时展示气泡提示。但是在
rc-menu中，有一个看不见的节点会对完整的 KV 路径进行收集。而看不见的节点会被 fallback 到findDOMNode提示 warning 信息。这个 fix 通过提供一个
_internalComponents用于定制组件，暂时不进行大的重构。让 antd 在渲染测使用自己的组件，而收集测使用原生组件。因此会对items执行两次结构生成。注意：该更新会降低 headless 下使用
rc-menu的性能。