fix: panel flick in some edge case #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
reviewed
Jul 15, 2022
| (direction === 'rtl' || arrowRef.current.offsetLeft > arrowLeft | ||
| ? 0 | ||
| : arrowRef.current.offsetLeft) | ||
| (direction === 'rtl' ? 0 : arrowMarginLeft) |
There was a problem hiding this comment.
这里是暂时没考虑 rtl 的 case，所以先忽略成 0，marginRight 相对来说算起来麻烦一些
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 46 46
Lines 2148 2149 +1
Branches 633 634 +1
=======================================
+ Hits 2138 2139 +1
Misses 8 8
Partials 2 2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@afc163 could you please bump a new package version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ant-design/ant-design#36507