refactor: Progress circle #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
afc163
commented
May 8, 2022
•
afc163
commented
- Refactor by following https://codepen.io/JMChristensen/pen/AGbeEy
- Resolve issues Progress type="circle"时，设置的percent数字为98，进度条却是占满100%的状态 ant-design/ant-design#35009 Progress 组件显示有锯齿 ant-design/ant-design#17706 Dashboard 对于 gapDegree 的绘制不准确 ant-design/ant-design#35352
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reduce half value of storkeWidth when strokeLinecap="round"
afc163
force-pushed
the
refactor/progress-circle
branch
from
5cc4ba9 to
e32bbdf
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 99.20% 99.11% -0.09%
==========================================
Files 4 4
Lines 125 113 -12
Branches 34 32 -2
==========================================
- Hits 124 112 -12
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
afc163
commented
May 8, 2022
Comment on lines
+41
to
+48
| // Fix percent accuracy when strokeLinecap is round | ||
| // https://github.com/ant-design/ant-design/issues/35009 | ||
| if (strokeLinecap === 'round' && percent !== 100) { | ||
| strokeDashoffset += strokeWidth / 2; | ||
| // when percent is small enough (<= 1%), keep smallest value to avoid it's disapperance | ||
| if (strokeDashoffset >= perimeterWithoutGap) { | ||
| strokeDashoffset = perimeterWithoutGap - 0.01; | ||
| } |
There was a problem hiding this comment.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.