Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename space => gap #275

Merged
merged 1 commit into from
Mar 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/examples/fast-progress.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import * as React from 'react';
import { Line, Circle, ProgressProps } from 'rc-progress';
import React from 'react';
import { Line, Circle } from 'rc-progress';
import type { ProgressProps } from 'rc-progress';

class App extends React.Component<ProgressProps, any> {
constructor(props) {
constructor(props: ProgressProps) {
super(props);
this.state = {
percent: 0,
Expand Down
20 changes: 11 additions & 9 deletions docs/examples/gap.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
import * as React from 'react';
import { Circle, type ProgressProps } from 'rc-progress';
import React from 'react';
import { Circle } from 'rc-progress';
import type { ProgressProps } from 'rc-progress';

const colorMap = ['#3FC7FA', '#85D262', '#FE8C6A', '#FF5959', '#BC3FFA'];

function getColor(index) {
const circleContainerStyle: React.CSSProperties = {
width: 200,
height: 200,
};

function getColor(index: number) {
return colorMap[(index + colorMap.length) % colorMap.length];
}

class Example extends React.Component<ProgressProps, any> {
constructor(props) {
constructor(props: ProgressProps) {
super(props);
this.state = {
percent: 100,
Expand Down Expand Up @@ -36,10 +42,6 @@ class Example extends React.Component<ProgressProps, any> {
}

render() {
const circleContainerStyle = {
width: '200px',
height: '200px',
};
const { percent, colorIndex, subPathsCount } = this.state;
const color = getColor(colorIndex);

Expand All @@ -48,7 +50,7 @@ class Example extends React.Component<ProgressProps, any> {
0,
subPathsCount,
);
const multiPercentageStrokeColors = multiPercentage.map((v, index) => getColor(index));
const multiPercentageStrokeColors = multiPercentage.map((_, i) => getColor(i));

return (
<div>
Expand Down
31 changes: 10 additions & 21 deletions docs/examples/gradient-circle.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import * as React from 'react';
import React from 'react';
import { Circle } from 'rc-progress';

const Example = () => {
const circleContainerStyle = {
width: '250px',
height: '250px',
display: 'inline-block',
};
const circleContainerStyle: React.CSSProperties = {
width: 250,
height: 250,
display: 'inline-block',
};

const Example: React.FC = () => {
return (
<div>
<h3>Circle Progress {90}%</h3>
Expand All @@ -16,10 +16,7 @@ const Example = () => {
percent={90}
strokeWidth={6}
strokeLinecap="round"
strokeColor={{
'0%': '#108ee9',
'100%': '#87d068',
}}
strokeColor={{ '0%': '#108ee9', '100%': '#87d068' }}
/>
</div>
<h3>Circle Progress {100}%</h3>
Expand All @@ -28,23 +25,15 @@ const Example = () => {
percent={100}
strokeWidth={6}
strokeLinecap="round"
strokeColor={{
'100%': '#108ee9',
'0%': '#87d068',
}}
strokeColor={{ '100%': '#108ee9', '0%': '#87d068' }}
/>
</div>

<h3>Circle colors</h3>
<div style={circleContainerStyle}>
<Circle
percent={90}
strokeWidth={6}
strokeColor={{
'0%': 'green',
'99%': 'red',
'100%': 'blue',
}}
strokeColor={{ '0%': 'green', '99%': 'red', '100%': 'blue' }}
/>
</div>
</div>
Expand Down
21 changes: 13 additions & 8 deletions docs/examples/simple.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import * as React from 'react';
import { Line, Circle, ProgressProps } from 'rc-progress';
import React from 'react';
import { Line, Circle } from 'rc-progress';
import type { ProgressProps } from 'rc-progress';

class Example extends React.Component<ProgressProps, any> {
constructor(props) {
constructor(props: ProgressProps) {
super(props);
this.state = {
percent: 9,
Expand All @@ -20,29 +21,33 @@ class Example extends React.Component<ProgressProps, any> {
percent: value,
color: colorMap[parseInt((Math.random() * 3).toString(), 10)],
});
};
}

changeIncrease() {
this.setState(({ percent }) => {
if (percent > 100) {
percent = 100;
return {
percent: 100,
};
}
return {
percent: percent + 1,
};
});
};
}

changeReduce() {
this.setState(({ percent }) => {
if (percent < 0) {
percent = 0;
return {
percent: 0,
};
}
return {
percent: percent - 1,
};
});
};
}

render() {
const { percent, color } = this.state;
Expand Down
94 changes: 47 additions & 47 deletions docs/examples/steps.tsx
Original file line number Diff line number Diff line change
@@ -1,76 +1,76 @@
import * as React from 'react';
import { useState } from 'react';
import React, { useState } from 'react';
import { Circle } from 'rc-progress';

const Example = () => {

const Example: React.FC = () => {
const [percent, setPercent] = useState<number>(30);
const [strokeWidth, setStrokeWidth] = useState<number>(20);
const [steps, setSteps] = useState<number>(5);
const [space, setSpace] = useState<number>(4);


const [gap, setGap] = useState<number>(4);
return (
<div>
<div>
percent: <input
id='range'
type='range'
min='0'
max='100'
value={percent}
style={{ width: 300 }}
onChange={(e) => setPercent(parseInt(e.target.value))} />
percent:
<input
id="range"
type="range"
min="0"
max="100"
value={percent}
style={{ width: 300 }}
onChange={(e) => setPercent(parseInt(e.target.value))}
/>
</div>
<div>
strokeWidth: <input
id='range'
type='range'
min='0'
max='30'
value={strokeWidth}
style={{ width: 300 }}
onChange={(e) => setStrokeWidth(parseInt(e.target.value))} />
strokeWidth:
<input
id="range"
type="range"
min="0"
max="30"
value={strokeWidth}
style={{ width: 300 }}
onChange={(e) => setStrokeWidth(parseInt(e.target.value))}
/>
</div>
<div>
steps: <input
id='range'
type='range'
min='0'
max='15'
value={steps}
style={{ width: 300 }}
onChange={(e) => setSteps(parseInt(e.target.value))} />
steps:
<input
id="range"
type="range"
min="0"
max="15"
value={steps}
style={{ width: 300 }}
onChange={(e) => setSteps(parseInt(e.target.value))}
/>
</div>
<div>
space: <input
id='range'
type='range'
min='0'
max='15'
value={space}
style={{ width: 300 }}
onChange={(e) => setSpace(parseInt(e.target.value))} />
space:
<input
id="range"
type="range"
min="0"
max="15"
value={gap}
style={{ width: 300 }}
onChange={(e) => setGap(parseInt(e.target.value))}
/>
</div>
<h3>Circle Progress:</h3>
<div>percent: {percent}% </div>
<div>strokeWidth: {strokeWidth}px</div>
<div>steps: {steps}</div>
<div>space: {space}px</div>

<div>gap: {gap}px</div>
<div style={{ width: 100 }}>
<Circle
percent={percent}
strokeWidth={strokeWidth}
steps={{
count: steps,
space: space,
}}
strokeColor={'red'}
steps={{ count: steps, gap: gap }}
strokeColor="red"
/>
</div>
</div>
);
};

export default Example;
export default Example;
13 changes: 2 additions & 11 deletions src/Circle/PtgCircle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,8 @@ interface BlockProps {
children?: React.ReactNode;
}

const Block = ({ bg, children }: BlockProps) => (
<div
style={{
width: '100%',
height: '100%',
background: bg,
}}
>
{children}
</div>
const Block: React.FC<BlockProps> = ({ bg, children }) => (
<div style={{ width: '100%', height: '100%', background: bg }}>{children}</div>
);

function getPtgColors(color: Record<string, string>, scale: number) {
Expand Down Expand Up @@ -97,7 +89,6 @@ const PtgCircle = React.forwardRef<SVGCircleElement, ColorGradientProps>((props,
return (
<>
<mask id={maskId}>{circleNode}</mask>

<foreignObject x={0} y={0} width={size} height={size} mask={`url(#${maskId})`}>
<Block bg={linearColorBg}>
<Block bg={conicColorBg} />
Expand Down
12 changes: 6 additions & 6 deletions src/Circle/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ const Circle: React.FC<ProgressProps> = (props) => {
const perimeter = Math.PI * 2 * radius;
const rotateDeg = gapDegree > 0 ? 90 + gapDegree / 2 : -90;
const perimeterWithoutGap = perimeter * ((360 - gapDegree) / 360);
const { count: stepCount, space: stepSpace } =
typeof steps === 'object' ? steps : { count: steps, space: 2 };
const { count: stepCount, gap: stepGap } =
typeof steps === 'object' ? steps : { count: steps, gap: 2 };

const percentList = toArray(percent);
const strokeColorList = toArray(strokeColor);
Expand Down Expand Up @@ -70,7 +70,7 @@ const Circle: React.FC<ProgressProps> = (props) => {
const getStokeList = () => {
let stackPtg = 0;
return percentList
.map((ptg, index) => {
.map<React.ReactNode>((ptg, index) => {
const color = strokeColorList[index] || strokeColorList[strokeColorList.length - 1];
const circleStyleForStack = getCircleStyle(
perimeter,
Expand Down Expand Up @@ -119,7 +119,7 @@ const Circle: React.FC<ProgressProps> = (props) => {
const stepPtg = 100 / stepCount;

let stackPtg = 0;
return new Array(stepCount).fill(null).map((_, index) => {
return new Array(stepCount).fill(null).map<React.ReactNode>((_, index) => {
const color = index <= current - 1 ? strokeColorList[0] : trailColor;
const stroke = color && typeof color === 'object' ? `url(#${gradientId})` : undefined;
const circleStyleForStack = getCircleStyle(
Expand All @@ -133,10 +133,10 @@ const Circle: React.FC<ProgressProps> = (props) => {
color,
'butt',
strokeWidth,
stepSpace,
stepGap,
);
stackPtg +=
((perimeterWithoutGap - circleStyleForStack.strokeDashoffset + stepSpace) * 100) /
((perimeterWithoutGap - (circleStyleForStack.strokeDashoffset as number) + stepGap) * 100) /
perimeterWithoutGap;

return (
Expand Down
7 changes: 4 additions & 3 deletions src/Circle/util.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { StrokeColorType } from '../interface';
import type { ProgressProps } from '..';
import type React from 'react';

export const VIEW_BOX_SIZE = 100;

Expand All @@ -9,13 +10,13 @@ export const getCircleStyle = (
offset: number,
percent: number,
rotateDeg: number,
gapDegree,
gapDegree: number,
gapPosition: ProgressProps['gapPosition'] | undefined,
strokeColor: StrokeColorType,
strokeLinecap: ProgressProps['strokeLinecap'],
strokeWidth,
strokeWidth: number,
stepSpace = 0,
) => {
): React.CSSProperties => {
const offsetDeg = (offset / 100) * 360 * ((360 - gapDegree) / 360);
const positionDeg =
gapDegree === 0
Expand Down
2 changes: 1 addition & 1 deletion src/Line.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const Line: React.FC<ProgressProps> = (props) => {
dashPercent = 1;
break;
}
const pathStyle = {
const pathStyle: React.CSSProperties = {
strokeDasharray: `${ptg * dashPercent}px, 100px`,
strokeDashoffset: `-${stackPtg}px`,
transition:
Expand Down
Loading
Loading