Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select's children must be Select.Option #84

Closed
benjycui opened this issue May 3, 2016 · 0 comments · Fixed by #88
Closed

Select's children must be Select.Option #84

benjycui opened this issue May 3, 2016 · 0 comments · Fixed by #88
Assignees
@benjycui

Comments

@benjycui
Copy link
Member

benjycui commented May 3, 2016

Select does not check children's type now.
@benjycui benjycui self-assigned this May 3, 2016
benjycui added a commit that referenced this issue May 16, 2016
@benjycui
fix: Select's children must be Option or OptGorup, close: #84
dc25796
@benjycui benjycui mentioned this issue May 16, 2016
Merged
yiminghe added a commit that referenced this issue May 17, 2016
@yiminghe
Merge pull request #88 from react-component/fix-children-type
7795027 
fix: `Select`'s children must be `Option` or `OptGorup`, close: #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjycui benjycui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Select's children must be Option or OptGorup, close: #84 react-component/select
1 participant
@benjycui