Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix header select bug #134

Merged
merged 1 commit into from
Nov 11, 2016
Merged

fix header select bug #134

merged 1 commit into from
Nov 11, 2016

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Nov 11, 2016

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.542% when pulling c429271 on RaoHai:HeaderSelect into 5164fd0 on react-component:master.

@afc163 afc163 merged commit 4441b58 into react-component:master Nov 11, 2016
@yiminghe
Copy link
Member

这个组件已经很复杂了，每次改动风险很大。下次改动要当面找我沟通

yiminghe added a commit that referenced this pull request Nov 11, 2016
@yiminghe
fix #134
3ada48a
@yesmeck
Copy link
Member

yesmeck commented Nov 14, 2016

@yiminghe 是不是考虑引入 jest 和 enzyme，然后测试补多一点，Option 的 value 类型的问题我也不大敢改。

@yiminghe
Copy link
Member

现在的测试有啥问题，主要是用例不足

@yesmeck
Copy link
Member

yesmeck commented Nov 14, 2016

用 jest 的 snapshot 写测试会方便点，enzyme 也是写测试方便。

@yiminghe
Copy link
Member

可以 pr 看下

@afc163 afc163 mentioned this pull request Nov 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaoHai @coveralls @yiminghe @yesmeck @afc163