Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on click placeholder #80

Closed
wants to merge 2 commits into from
Closed

Fix error on click placeholder #80

wants to merge 2 commits into from

Conversation

superRaytin
Copy link
Contributor

close #79

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 76.555% when pulling d22d4ac on superRaytin:fix-error-on-click-placeholder into 7afbdc0 on react-component:master.

@superRaytin
Copy link
Contributor Author

coveralls 没过，但是没看懂为什么 @yiminghe 帮忙看看？

yiminghe
yiminghe reviewed Apr 27, 2016
View reviewed changes
src/Select.jsx
@@ -276,7 +276,9 @@ const Select = React.createClass({
},

onPlaceholderClick() {
this.getInputDOMNode().focus();
if (this.props.showSearch) {
this.getInputDOMNode().focus();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(this.getInputDOMNode()){
this.getInputDOMNode().focus();
}

@yiminghe yiminghe closed this in b65e4f3 Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click placeholder throws error when showSearch is set to false
3 participants
@superRaytin @coveralls @yiminghe