fix forcePopupAlign null

react-component · Nov 17, 2020 · 69dc592 · 69dc592
1 parent a92703d
commit 69dc592
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 19 deletions.
diff --git a/src/common/SliderTooltip.tsx b/src/common/SliderTooltip.tsx
@@ -17,7 +17,7 @@ const SliderTooltip = React.forwardRef<unknown, TooltipProps>((props, ref) => {
 
   function keepAlign() {
     rafRef.current = raf(() => {
-      innerRef.current.forcePopupAlign();
+      innerRef.current?.forcePopupAlign();
     });
   }
 

diff --git a/tests/common/SliderTooltip.test.js b/tests/common/SliderTooltip.test.js
@@ -3,22 +3,37 @@ import { mount } from 'enzyme';
 import { act } from 'react-dom/test-utils';
 import SliderTooltip from '../../src/common/SliderTooltip';
 
-it('should keepAlign by calling forcePopupAlign', async () => {
-  let ref;
-  mount(
-    <SliderTooltip
-      title="30"
-      visible
-      ref={node => {
-        ref = node;
-      }}
-    >
-      <span>aaaa</span>
-    </SliderTooltip>,
-  );
-  ref.forcePopupAlign = jest.fn();
-  await act(async () => {
-    await new Promise(res => setTimeout(res, 200));
+describe('SliderTooltip', () => {
+  it('should keepAlign by calling forcePopupAlign', async () => {
+    let ref;
+    mount(
+      <SliderTooltip
+        title="30"
+        visible
+        ref={node => {
+          ref = node;
+        }}
+      >
+        <span>aaaa</span>
+      </SliderTooltip>,
+    );
+    ref.forcePopupAlign = jest.fn();
+    await act(async () => {
+      await new Promise(res => setTimeout(res, 200));
+    });
+    expect(ref.forcePopupAlign).toHaveBeenCalled();
   });
-  expect(ref.forcePopupAlign).toHaveBeenCalled();
-});
+
+  it('should not crash when unmount', async () => {
+    const wrapper = mount(
+      <SliderTooltip
+        title="30"
+        visible
+      >
+        <span>aaaa</span>
+      </SliderTooltip>,
+    );
+    wrapper.unmount();
+  });
+})
+