pushable inaccuracy #305
Merged
pushable inaccuracy #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Robin-front Thanks for your PR. I noticed that you have helped us fixed many problems. I'd like to invite you to be a Collaborators of rc-slider, you can click this link if you are willing too https://github.com/react-component/slider/invitations |
paranoidjk
reviewed
Sep 15, 2017
| @@ -219,7 +218,7 @@ class Range extends React.Component { | |||
| const diffToNext = direction * (bounds[nextHandle] - value); | |||
| if (!this.pushHandle(bounds, nextHandle, direction, threshold - diffToNext)) { | |||
| // revert to original value if pushing is impossible | |||
| bounds[handle] = originalValue; | |||
| bounds[handle] = bounds[nextHandle] - (direction * threshold); | |||
There was a problem hiding this comment.
yes, there is implicit-conversion when calculate. But of course, it's not serious. I will change to explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace: #199