Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotStyle and activeDotStyle #292

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

tomoberry
Copy link
Contributor

I was thinking something like this for adding styling to the dots

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.324% when pulling 665708a on tomoberry:dot-style into 89353ad on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.324% when pulling 1821a81 on tomoberry:dot-style into 89353ad on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.324% when pulling fc8680d on tomoberry:dot-style into 89353ad on react-component:master.

@benjycui
Copy link
Member

benjycui commented Jul 3, 2017

😒

@paranoidjk
Copy link
Member

@tomoberry

Thanks for you pr.
But since we have rc-slider-dot, rc-slider-dot-active classname, why not custom style with css?

@tomoberry
Copy link
Contributor Author

I have a use case where I need to support an arbitrary number of different color combinations for the slider. A simple example would be making an ajax call to a server that returns a random color that the slider should be displayed in.

@paranoidjk
Copy link
Member

paranoidjk commented Jul 4, 2017

hmm, i got this feature request from another user too.

So i am going to merge this and release a minor upgrade.

@paranoidjk paranoidjk merged commit f571a1e into react-component:master Jul 4, 2017
@paranoidjk
Copy link
Member

rc-slider@8.2.0

paranoidjk added a commit to ant-design/ant-design-mobile that referenced this pull request Jul 4, 2017
paranoidjk added a commit to ant-design/ant-design that referenced this pull request Jul 4, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants