-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix floating-point arithmetic issues when props are decimals. #619
Open
jcfrancisco
wants to merge
2
commits into
react-component:master
Choose a base branch
from
DataDog:jcfrancisco/fix-floating-point-arith
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import { findDOMNode } from 'react-dom'; | ||
import keyCode from 'rc-util/lib/KeyCode'; | ||
|
||
const MAX_PRECISION_FOR_OPERATIONS = 15; | ||
|
||
export function isEventFromHandle(e, handles) { | ||
try { | ||
return Object.keys(handles) | ||
|
@@ -19,28 +21,51 @@ export function isNotTouchEvent(e) { | |
(e.type.toLowerCase() === 'touchend' && e.touches.length > 0); | ||
} | ||
|
||
export function getPrecision(step) { | ||
const stepString = step.toString(); | ||
let precision = 0; | ||
if (stepString.indexOf('.') >= 0) { | ||
precision = stepString.length - stepString.indexOf('.') - 1; | ||
} | ||
return precision; | ||
} | ||
|
||
function withPrecision(value, precision) { | ||
return parseFloat(value.toFixed(precision)); | ||
} | ||
|
||
// safeDivideBy and safeMultiply: if either term is a float, | ||
// then round the result to the combined precision | ||
|
||
function safeDivideBy(a, b) { | ||
const precision = Math.min( | ||
getPrecision(a) + getPrecision(b), | ||
MAX_PRECISION_FOR_OPERATIONS | ||
); | ||
return precision === 0 ? a / b : withPrecision(a / b, precision); | ||
} | ||
|
||
function safeMultiply(a, b) { | ||
const precision = Math.min( | ||
getPrecision(a) + getPrecision(b), | ||
MAX_PRECISION_FOR_OPERATIONS | ||
); | ||
return withPrecision(a * b, precision); | ||
} | ||
|
||
export function getClosestPoint(val, { marks, step, min, max }) { | ||
const points = Object.keys(marks).map(parseFloat); | ||
if (step !== null) { | ||
const maxSteps = Math.floor((max - min) / step); | ||
const steps = Math.min((val - min) / step, maxSteps); | ||
const maxSteps = Math.floor(safeDivideBy(max - min, step)); | ||
const steps = Math.min(safeDivideBy(val - min, step), maxSteps); | ||
const closestStep = | ||
Math.round(steps) * step + min; | ||
safeMultiply(Math.round(steps), step) + min; | ||
points.push(closestStep); | ||
} | ||
const diffs = points.map(point => Math.abs(val - point)); | ||
return points[diffs.indexOf(Math.min(...diffs))]; | ||
} | ||
|
||
export function getPrecision(step) { | ||
const stepString = step.toString(); | ||
let precision = 0; | ||
if (stepString.indexOf('.') >= 0) { | ||
precision = stepString.length - stepString.indexOf('.') - 1; | ||
} | ||
return precision; | ||
} | ||
|
||
export function getMousePosition(vertical, e) { | ||
return vertical ? e.clientY : e.pageX; | ||
} | ||
|
@@ -70,7 +95,7 @@ export function ensureValuePrecision(val, props) { | |
const { step } = props; | ||
const closestPoint = isFinite(getClosestPoint(val, props)) ? getClosestPoint(val, props) : 0; // eslint-disable-line | ||
return step === null ? closestPoint : | ||
parseFloat(closestPoint.toFixed(getPrecision(step))); | ||
withPrecision(closestPoint, getPrecision(step)); | ||
Comment on lines
-73
to
+98
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can back out this refactor if it's unwanted |
||
} | ||
|
||
export function pauseEvent(e) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is untouched, moved it up because I'm using it elsewhere.