Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stepIcon renderer #118

Merged
merged 20 commits into from
Jul 24, 2020
Merged

Conversation

kingwubin
Copy link
Contributor

@kingwubin kingwubin commented Jul 13, 2020

feat($step):增加precess状态下的进度特性,以百分比来展示,以及popover效果

变更点

step:steps的props里增加了progressPercentage的接口,在rc的step组件中进行调用,该函数返回reactNode,该接口的功能与progressDot类似,progressPercentage函数在antd中进行定义,在antd中,可以复用progress组件实现进度效果,进度的百分比也在antd中设置与实现;最外层div增加了的ant-steps-percentage的className,提供样式修改的能力;

增加的特性如图所示:

image

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #118 into master will increase coverage by 6.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   91.78%   98.63%   +6.84%     
==========================================
  Files           2        2              
  Lines          73       73              
  Branches       25       25              
==========================================
+ Hits           67       72       +5     
+ Misses          6        1       -5     
Impacted Files Coverage Δ
src/Step.tsx 97.77% <100.00%> (+9.40%) ⬆️
src/Steps.tsx 100.00% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a631e8...aa23bc8. Read the comment docs.

@yoyo837
Copy link
Member

yoyo837 commented Jul 14, 2020

请添加测试用例

package.json Outdated Show resolved Hide resolved
assets/small.less Outdated Show resolved Hide resolved
src/Step.tsx Outdated Show resolved Hide resolved
src/Step.tsx Outdated Show resolved Hide resolved
src/Step.tsx Outdated Show resolved Hide resolved
src/Steps.tsx Outdated Show resolved Hide resolved
examples/progressPercentage.jsx Outdated Show resolved Hide resolved
src/Step.tsx Outdated Show resolved Hide resolved
src/Steps.tsx Outdated Show resolved Hide resolved
src/Steps.tsx Outdated Show resolved Hide resolved
src/Steps.tsx Outdated Show resolved Hide resolved
src/Steps.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Jul 22, 2020

看了一下,这个 progress 似乎就是管 icon 的,建议类似 Table 的 expandable.expandIcon 一样直接叫做 stepIcon 属性更好懂。

src/Steps.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jul 22, 2020

标题和内容不符。

examples/stepIcon.jsx Outdated Show resolved Hide resolved
@07akioni 07akioni requested a review from zombieJ July 23, 2020 03:37
@07akioni 07akioni requested a review from afc163 July 23, 2020 03:37
src/Steps.tsx Show resolved Hide resolved
src/Step.tsx Outdated Show resolved Hide resolved
@afc163 afc163 changed the title 增加precess状态下的进度特性,以百分比来展示,以及popover效果 feat: Add stepIcon renderer Jul 23, 2020
src/Step.tsx Outdated Show resolved Hide resolved
@07akioni 07akioni requested a review from zombieJ July 24, 2020 08:00
examples/stepIcon.jsx Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 9d3d31a into react-component:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants