Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize sticky scroll bar visible check #1078

Closed
wants to merge 5 commits into from
Closed

fix: optimize sticky scroll bar visible check #1078

wants to merge 5 commits into from

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Feb 7, 2024 •
edited
Loading

ref #1076

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 0:29am

zombieJ
zombieJ reviewed Feb 7, 2024
View reviewed changes
src/stickyScrollBar.tsx Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (886671b) 50.25% compared to head (be9e9a7) 50.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
- Coverage   50.25%   50.24%   -0.01%     
==========================================
  Files          97       97              
  Lines        9072     9071       -1     
  Branches      633      633              
==========================================
- Hits         4559     4558       -1     
  Misses       4463     4463              
  Partials       50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linxianxi linxianxi requested a review from zombieJ February 7, 2024 08:01
afc163
afc163 requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

render 阶段内不应该读 dom，服务端渲染会挂。

@linxianxi linxianxi closed this Mar 29, 2024
@linxianxi linxianxi mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 requested changes

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linxianxi @afc163 @zombieJ