Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements overriding #171

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Elements overriding #171

merged 3 commits into from
Nov 13, 2017

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Oct 25, 2017

This PR addresses many long living issues.

Added components to allow overriding default table elements.

const components = {
  table: MyTable,
  header: {
    wrapper: HeaderWrapper,
    row: HeaderRow,
    cell: HeaderCell,
  },
  body: {
    wrapper: BodyWrapper,
    row: BodyRow,
    cell: BodyCell,
  },
};

<Table components={components} columns={columns data={data}}  />

Added onRow, onHeaderRow, column[onCell] and column[onHeaderCell] to allow overriding row and cell props.

Integrate with react-dnd

See https://yesmeck.github.io/table/examples/react-dnd.html

Close ant-design/ant-design#4639, #83

Integrate with styled-components

See https://yesmeck.github.io/table/examples/styled-components.html.

Ability to add any event listener to the table element with onRow and onCell

Don't need add tons of onRowXXX props.

const onRow = (record) => ({
  onClick() { alert(`Clicked ${record.name}`) },
});
<Table columns={columns} data={data} onRow={onRow} />

Close ant-design/ant-design#7096, #127, #141, #117, #149

Ability to optimize table row with sCU

class OptimizedRow extends React.Component {
  shouldComponentUpdate(nextProps) {
    // Perform a custom check
  }

  render() {
    return (
      <tr {...this.props } />
    )
  }
}

<Table components={{ body: { row: OptimizedRow } }} />

Related ant-design/ant-design#2884

Others

Close ant-design/ant-design#5776, #139

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 97.861% when pulling 715ff05 on elements-overriding into 3e5ad89 on master.

@yesmeck yesmeck force-pushed the elements-overriding branch from 715ff05 to 4c8d472 Compare October 25, 2017 02:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 97.861% when pulling 4c8d472 on elements-overriding into 3e5ad89 on master.

@afc163
Copy link
Member

afc163 commented Oct 25, 2017

#137

@yesmeck
Copy link
Member Author

yesmeck commented Oct 25, 2017

Yeah, aligned cell can be implemented through custom component:

const CenterCell = (props) => <th {...props} style={{ textAlign: 'center' }} />;

<Table components={{ body: { cell: CenterCell } }} />

@afc163
Copy link
Member

afc163 commented Oct 25, 2017

column.align will be easier to use.

@yesmeck yesmeck force-pushed the elements-overriding branch from 4c8d472 to ac3c4de Compare October 25, 2017 07:42
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.895% when pulling ac3c4de on elements-overriding into 0a9207b on master.

@yesmeck
Copy link
Member Author

yesmeck commented Oct 25, 2017

After introducing onRow and column[onCell], we can deprecate onRowClick, onRowDoubleClick, onRowMouseEnter, onRowMouseLeave, onRowContextMenu, column[onCellClick].

@yesmeck
Copy link
Member Author

yesmeck commented Oct 25, 2017

getBodyWrapper can be deprecated as well.

@yesmeck yesmeck force-pushed the elements-overriding branch from ac3c4de to e7458ae Compare October 26, 2017 08:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 96.875% when pulling e7458ae on elements-overriding into 0a9207b on master.

@liuyangc3
Copy link

liuyangc3 commented Aug 17, 2018

Ability to add any event listener to the table element with onRow and onCell
Don't need add tons of onRowXXX props.

补充一下 onCell 是在 columns 里, 看上面的例子 还以为是写在 Table

const columns = { 
  onCell: record => ({
    onClick() { alert(`Clicked ${record.name}`) },
  }),
}
<Table columns={columns} data={data} onRow={onRow} />

@creeefs
Copy link

creeefs commented Jun 28, 2019

@yesmeck Is there a way to just wrap the body.row element without having to manually re-create it?

@ashirbad29
Copy link

do components work in virtual table ? I have been trying to add a custom row component but it seems it is getting ignored when virtual table is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants