Pass data-* and aria-* props to the body table component #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 93.58% 93.62% +0.04%
==========================================
Files 17 17
Lines 748 753 +5
Branches 196 196
==========================================
+ Hits 700 705 +5
Misses 40 40
Partials 8 8
Continue to review full report at Codecov.
|
| @@ -163,7 +165,7 @@ class BaseTable extends React.Component { | |||
| const columns = this.getColumns(); | |||
|
|
|||
| return ( | |||
| <Table className={tableClassName} style={tableStyle} key="table"> | |||
| <Table className={tableClassName} style={tableStyle} key="table" {...dataOrAriaProps}> | |||
There was a problem hiding this comment.
Why not pass them to
Lines 497 to 502 in 479bd2e
There was a problem hiding this comment.
My thought is that attributes would be assigned on the native elements that these components represent, when available. On Input it would be on <input>, on Table it would go to the <table>. Others like Select don't use the native html elements, so then it would go to whatever wrapper makes sense.
There was a problem hiding this comment.
But I see your point, thats where props.id and props.style is assigned, so it might make the most sense.
|
+1 |
|
Can this one be merged please? I will really aid in an accessibility issue that we are having. |
|
Closing in favor of #227 |
Pass data-* and aria-* props to the body table component