Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use father & typescript #375

Merged
merged 15 commits into from
Oct 15, 2019
Merged

refactor: Use father & typescript #375

merged 15 commits into from
Oct 15, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 15, 2019

No description provided.

@zombieJ zombieJ requested a review from afc163 October 15, 2019 12:07
@vercel
Copy link

vercel bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/table/jc7ljvizt
🌍 Preview: https://table-git-ts.react-component.now.sh

@zombieJ zombieJ requested a review from yesmeck October 15, 2019 12:07
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #375 into master will decrease coverage by 3.23%.
The diff coverage is 95.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   93.22%   89.98%   -3.24%     
==========================================
  Files          17       16       -1     
  Lines         738      819      +81     
  Branches      216      229      +13     
==========================================
+ Hits          688      737      +49     
- Misses         41       82      +41     
+ Partials        9        0       -9
Impacted Files Coverage Δ
src/ExpandableRow.tsx 97.5% <100%> (ø)
src/TableHeader.tsx 100% <100%> (ø)
src/TableHeaderRow.tsx 96.29% <100%> (ø)
src/ColumnGroup.tsx 100% <100%> (ø)
src/Column.tsx 100% <100%> (ø)
src/BaseTable.tsx 100% <100%> (ø)
src/ColumnManager.tsx 98.78% <100%> (ø)
src/BodyTable.tsx 94.11% <100%> (ø)
src/ExpandableTable.tsx 98.83% <100%> (ø)
src/ExpandIcon.tsx 100% <100%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac616d...dd70fe0. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 15, 2019

This pull request introduces 10 alerts and fixes 1 when merging 06f3de2 into 9ac616d - view on LGTM.com

new alerts:

  • 8 for Assignment to constant
  • 1 for Missing space in string concatenation
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Missing space in string concatenation

@vercel vercel bot temporarily deployed to staging October 15, 2019 12:32 Inactive
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 15, 2019

This pull request introduces 2 alerts and fixes 2 when merging dd70fe0 into 9ac616d - view on LGTM.com

new alerts:

  • 1 for Missing space in string concatenation
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Missing space in string concatenation
  • 1 for Potentially inconsistent state update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant