Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "getPopupContainer" prop #491

Merged

Conversation

yuantongkang
Copy link
Contributor

@yuantongkang yuantongkang commented Mar 21, 2022

Takes over this abandoned PR: #320 PR: #486

close #320
close #486

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/B4PPnBKq8ufTBjjS7wGyYwMuR52S
✅ Preview: https://tabs-git-fork-yuantongkang-kangyuantong-cb4637-react-component.vercel.app

@yuantongkang yuantongkang changed the title Kangyuantong get popup container Adding "getPopupContainer" prop Mar 21, 2022
@yoyo837
Copy link
Member

yoyo837 commented Jun 16, 2022

Conflicted, rebase please.

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabs ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 0:54AM (UTC)

@yuantongkang
Copy link
Contributor Author

Conflicted, rebase please.

done

@yoyo837
Copy link
Member

yoyo837 commented Jun 22, 2022

Please add a test case for this.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #491 (1c4252a) into master (1888910) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          13       13           
  Lines         564      564           
  Branches      140      140           
=======================================
  Hits          561      561           
  Misses          3        3           
Impacted Files Coverage Δ
src/TabNavList/OperationNode.tsx 100.00% <ø> (ø)
src/TabNavList/index.tsx 99.45% <ø> (ø)
src/Tabs.tsx 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yuantongkang
Copy link
Contributor Author

yuantongkang commented Jun 22, 2022

Please add a test case for this.

already added test case

@yoyo837 yoyo837 merged commit 9892d51 into react-component:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants