refactor: refactor indicator props #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
li-jia-nan
commented
Jan 3, 2024
•
li-jia-nan
commented
- Add a property "indicatorPosition" to Tabs component ant-design/ant-design#46191 (comment)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 18 18
Lines 702 703 +1
Branches 191 192 +1
=======================================
+ Hits 686 687 +1
Misses 16 16 ☔ View full report in Codecov by Sentry. |
li-jia-nan
commented
Jan 4, 2024
| } = props; | ||
|
|
||
| const mergedIndicatorSize = indicator?.size || indicatorSize; |
There was a problem hiding this comment.
这个兼容废弃 api 的逻辑是不是写在 antd 里面比较好一点呢？
afc163
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.