Simplify _cacheTreeNodesStates assignment

react-component · Jan 5, 2017 · 9cab83b · 9cab83b
1 parent 0e35943
commit 9cab83b
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/Select.jsx b/src/Select.jsx
@@ -182,14 +182,11 @@ const Select = React.createClass({
   componentWillReceiveProps(nextProps) {
     // save parsed treeData, for performance (treeData may be very big)
     this.renderedTreeData = this.renderTreeData(nextProps);
-    if (this._cacheTreeNodesStates !== 'no' &&
-      this._savedValue && nextProps.value === this._savedValue) {
-      // Detecting whether the object of `onChange`'s argument  is old ref.
-      // Better to do a deep equal later.
-      this._cacheTreeNodesStates = true;
-    } else {
-      this._cacheTreeNodesStates = false;
-    }
+    // Detecting whether the object of `onChange`'s argument  is old ref.
+    // Better to do a deep equal later.
+    this._cacheTreeNodesStates = this._cacheTreeNodesStates !== 'no' &&
+                                 this._savedValue &&
+                                 nextProps.value === this._savedValue;
     if (this.props.treeData !== nextProps.treeData ||
       this.props.children !== nextProps.children) {
       // refresh this._treeNodesStates cache