Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mount scrollTo on ref #298

Merged
merged 15 commits into from
Dec 28, 2020
Merged

feat: mount scrollTo on ref #298

merged 15 commits into from
Dec 28, 2020

Conversation

atzcl
Copy link
Contributor

@atzcl atzcl commented Nov 17, 2020

scrollTo 能力暴露出来

相关 issue:
ant-design/ant-design#24240

相关 PR:
react-component/tree#393
react-component/select#565

@vercel
Copy link

vercel bot commented Nov 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tree-select/ff2w19y1a
✅ Preview: https://tree-select-git-fork-atzcl-master.react-component.vercel.app

@atzcl
Copy link
Contributor Author

atzcl commented Nov 17, 2020

编译挂了,需要等这个 PR 的完成:react-component/tree#393

@atzcl
Copy link
Contributor Author

atzcl commented Dec 25, 2020

@zombieJ 大佬,是暴露这样的能力出来不好吗?

@afc163
Copy link
Member

afc163 commented Dec 28, 2020

rebase

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #298 (1904bc4) into master (6a066cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          524       523    -1     
  Branches       147       155    +8     
=========================================
- Hits           524       523    -1     
Impacted Files Coverage Δ
src/TreeSelect.tsx 100.00% <ø> (ø)
src/OptionList.tsx 100.00% <100.00%> (ø)
src/utils/valueUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a066cd...1904bc4. Read the comment docs.

@afc163 afc163 merged commit 959e1ef into react-component:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants