fix pop node height 100%

close ant-design/ant-design#5092
react-component · Feb 28, 2017 · 705b53c · 705b53c
1 parent da5bbc2
commit 705b53c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Trigger.jsx b/src/Trigger.jsx
@@ -74,6 +74,7 @@ const Trigger = React.createClass({
         popupContainer.style.top = '0';
         popupContainer.style.left = '0';
         popupContainer.style.width = '100%';
+        popupContainer.style.height = '100%';
         const mountNode = props.getPopupContainer ?
                 props.getPopupContainer(findDOMNode(instance)) : props.getDocument().body;
         mountNode.appendChild(popupContainer);

diff --git a/tests/index.js b/tests/index.js
@@ -654,5 +654,22 @@ describe('rc-trigger', function main() {
       // height should be same, should not have break lines inside words
       expect(popupNodeHeightOfOneWord).to.equal(popupNodeHeightOfSeveralWords);
     });
+
+    // https://github.com/ant-design/ant-design/issues/5092
+    it('popup node height should be 100% as body', () => {
+      const trigger = ReactDOM.render(
+        <Trigger
+          popupVisible
+          popupAlign={placementAlignMap.top}
+          popup={<span>i am a pop up</span>}
+          popupStyle={{ height: '100%' }}
+        >
+          <div>trigger</div>
+        </Trigger>
+      , div);
+
+      // height should be same, should not have break lines inside words
+      expect(trigger.getPopupDomNode().offsetHeight).to.above(0);
+    });
   });
 });